talk-android
talk-android copied to clipboard
fix nfc
fix #5303
🚧 TODO
- [ ] ...
🏁 Checklist
- [ ] ⛑️ Tests (unit and/or integration) are included or not needed
- [ ] 🔖 Capability is checked or not needed
- [ ] 🔙 Backport requests are created or not needed:
/backport to stable-xx.x - [ ] 📅 Milestone is set
- [ ] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)
related:
- https://github.com/nextcloud/talk-android/issues/2136
- https://github.com/nextcloud/android/pull/10311
- https://github.com/nextcloud/talk-android/issues/5473 (maybe related. i just saw there were some logs containing NFC...)
Codacy
Lint
| Type | master | PR |
| Warnings | 99 | 99 |
| Errors | 0 | 0 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 6 | 6 |
| Correctness | 10 | 10 |
| Dodgy code | 54 | 54 |
| Internationalization | 3 | 3 |
| Malicious code vulnerability | 3 | 3 |
| Performance | 4 | 4 |
| Security | 1 | 1 |
| Total | 81 | 81 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5589.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.