nextcloud
add play button for video messages
Resolve #5568
🖼️ Screenshots
| 🏚️ Before | 🏡 After |
|---|---|
🚧 TODO
- [ ] ...
🏁 Checklist
- [ ] ⛑️ Tests (unit and/or integration) are included or not needed
- [ ] 🔖 Capability is checked or not needed
- [ ] 🔙 Backport requests are created or not needed:
/backport to stable-xx.x - [ ] 📅 Milestone is set
- [ ] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5585.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codacy
Lint
| Type | master | PR |
| Warnings | 99 | 99 |
| Errors | 0 | 0 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 6 | 6 |
| Correctness | 10 | 10 |
| Dodgy code | 54 | 54 |
| Internationalization | 3 | 3 |
| Malicious code vulnerability | 3 | 3 |
| Performance | 4 | 4 |
| Security | 1 | 1 |
| Total | 81 | 81 |
Issue but I am not sure it is easy to solve...
Incoming no preview but icon fallback
Same for outgoing
Can't tell if a layered drawable would work, also expect the loading spinner has the same issue but harder to spot given it is not permanently shown. The issue is basically that the image view of the preview seems stretched based on the outer container element via the flex-box logic.
