talk-android icon indicating copy to clipboard operation
talk-android copied to clipboard

Show delete all messages in 1:1 only when canDeleteConversation is true

Open sowjanyakch opened this issue 6 months ago • 1 comments

  • show delete all messages in one to one conversation only when canDeleteConversation is true

🚧 TODO

  • [ ] ...

🏁 Checklist

  • [ ] ⛑️ Tests (unit and/or integration) are included or not needed
  • [ ] 🔖 Capability is checked or not needed
  • [ ] 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • [ ] 📅 Milestone is set
  • [ ] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

sowjanyakch avatar Jun 30 '25 15:06 sowjanyakch

~~For a followup PR: please also add "Delete all messages" to the context menu of a conversation in conversation list (if setting is enabled). There should be the same entries as in ConversationInfo screen, with the same order.~~

update: @sowjanyakch i checked on sever and there it's also not in the context menu, so just forget about about it

mahibi avatar Jul 01 '25 08:07 mahibi

/backport to stable-21.1

mahibi avatar Jul 01 '25 08:07 mahibi

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5099-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

github-actions[bot] avatar Jul 01 '25 09:07 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings10096
Errors100

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code6161
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9494

github-actions[bot] avatar Jul 01 '25 09:07 github-actions[bot]