talk-android
talk-android copied to clipboard
Fixing a recording glitch
- fix https://github.com/nextcloud/talk-android/issues/3552
Main bug should be fixed however,
Noticing bug where after
- Entering locked mode
- Flipping orientation twice
- Exiting locked mode
- Flipping again -> causing spreedCapabilities to be null
🏁 Checklist
- [ ] ⛑️ Tests (unit and/or integration) are included or not needed
- [ ] 🔖 Capability is checked or not needed
- [ ] 🔙 Backport requests are created or not needed:
/backport to stable-xx.x - [ ] 📅 Milestone is set
- [ ] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)
Codacy
Lint
| Type | master | PR |
| Warnings | 98 | 97 |
| Errors | 9 | 9 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 6 | 6 |
| Correctness | 222 | 118 |
| Dodgy code | 71 | 71 |
| Internationalization | 3 | 3 |
| Malicious code vulnerability | 3 | 3 |
| Performance | 4 | 4 |
| Security | 1 | 1 |
| Total | 310 | 206 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4802-talk.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.