[Bug Fix] Clear FLAG_SECURE after passcode screen

[parneet-guraya]

Fixes #4164 #4076

🏁 Checklist

• [x] ⛑️ Tests (unit and/or integration) are included or not needed
• [x] 🔖 Capability is checked or not needed
• [ ] 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• [ ] 📅 Milestone is set
• [x] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4172-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	86	92
Errors	131	131

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	11	11
Dodgy code	78	78
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	108	108

Lint increased!

[mahibi]

i just saw by coincidence the PR https://github.com/nextcloud/talk-android/pull/3716 from @sowjanyakch that introduced the || appPreferences.isScreenLocked

@sowjanyakch can you summarize why this was done?

[sowjanyakch]

PR https://github.com/nextcloud/talk-android/pull/3716 introduced || appPreferences.isScreenLocked to hide the screen contents from recents screen when screen lock is enabled. However, this created an issue https://github.com/nextcloud/talk-android/issues/4076. @parneet-guraya can you try to fix https://github.com/nextcloud/talk-android/issues/4076 without breaking the feature hiding screen contents from recents screen?

[github-actions[bot]]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[mahibi]

i will close this PR as first of all the new Lock screen should be implemented, see https://github.com/nextcloud/talk-android/issues/3815#issuecomment-2401640132

Removing appPreferences.isScreenLocked would introduce other problems. We can have a look at it again when the new screen lock is implemented.

Thank you very much @parneet-guraya :+1: and sorry it took so long to have a clear roadmap for this.