talk-android
talk-android copied to clipboard
Animated GIFS in Chat
- fixes #3975
Paused to focus on offline support
🖼️ Screenshots
🚧 TODO
- [x] Fix Downloading to Cache
- [x] Make Gifs bigger
- [ ] Fix weird bug with images. Gifs are saved to cache, but the placeholder image is an unrelated photo.
- [x] Debug the previewMessageViewHolder. isGif is working, it's a problem with the image loader.
- [x] Debug the image loader. Image loader works fine, its the link that's an Image. But getting the gif link leads to an SSL exception -_-.
- [ ] Debug the GifImageView. Perhaps it's saving previous image state, which could be messing things up.
🏁 Checklist
- [ ] ⛑️ Tests (unit and/or integration) are included or not needed
- [ ] 🔖 Capability is checked or not needed
- [ ] 🔙 Backport requests are created or not needed:
/backport to stable-xx.x - [ ] 📅 Milestone is set
- [x] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)
Great!!!
Codacy
Lint
| Type | master | PR |
| Warnings | 90 | 90 |
| Errors | 129 | 129 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 6 | 6 |
| Correctness | 11 | 11 |
| Dodgy code | 78 | 78 |
| Internationalization | 3 | 3 |
| Malicious code vulnerability | 3 | 3 |
| Performance | 6 | 6 |
| Security | 1 | 1 |
| Total | 108 | 108 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4030-talk.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.