talk-android icon indicating copy to clipboard operation
talk-android copied to clipboard

Contacts activity

Open sowjanyakch opened this issue 1 year ago • 1 comments

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • [ ] ...

🏁 Checklist

  • [ ] ⛑️ Tests (unit and/or integration) are included or not needed
  • [ ] 🔖 Capability is checked or not needed
  • [ ] 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • [ ] 📅 Milestone is set
  • [ ] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

sowjanyakch avatar May 22 '24 14:05 sowjanyakch

Great to have a kickoff with jetpack compose :rocket: From my side this can be merged once the remarks from Julius are solved and issues/features should be fixed/done in followup PRs.

mahibi avatar Jul 12 '24 08:07 mahibi

One thing i realized when testing are some bugs that existed already before this PR:

  1. I have 2 accounts on sermo and with my account "Marcel" i am not able to see the account "marcel2" in the contacts. Maybe i get something wrong but i don't have an idea which could explain why it shouldn't be shown. When i search for it, it appears, but it's not in the list by default.

  2. When opening a conversation and go to Conversation info to add participants, the search is broken. When i enter a name, it won't appear in the results list. Then i delete the search and try and, and then more results appear than before. Bug report is https://github.com/nextcloud/talk-android/issues/2037

mahibi avatar Jul 12 '24 08:07 mahibi

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3936-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

github-actions[bot] avatar Jul 12 '24 10:07 github-actions[bot]

@sowjanyakch Can you rebase on master? Or as the rebase was not done regulary and may be difficult now, you can also merge master into this branch. For future branches please always use rebase and do it regulary.

please also fix warnings from https://app.codacy.com/gh/nextcloud/talk-android/pull-requests/3936/issues

mahibi avatar Jul 15 '24 10:07 mahibi