i18n: Change to capital letter

[Valdnet]

[Valdnet]

@mahibi After removing spaces in a text string: <string name="nc_edited_by">"Edited by"</string>

You need to add a space at the end of this string: https://github.com/nextcloud/talk-android/blob/e98f60d8846d35b7d5df39ca2ec15ecc60ecd25a/app/src/main/java/com/nextcloud/talk/ui/dialog/MessageActionsDialog.kt#L390

[mahibi]

@mahibi After removing spaces in a text string: <string name="nc_edited_by">"Edited by"</string>

You need to add a space at the end of this string:

https://github.com/nextcloud/talk-android/blob/e98f60d8846d35b7d5df39ca2ec15ecc60ecd25a/app/src/main/java/com/nextcloud/talk/ui/dialog/MessageActionsDialog.kt#L390

ah seeing this only now. I suggested to change it like this

[sowjanyakch]

I could not perform string formatting on the string "nc_edited_by" (modified its value to "Edited by %1$s") for some reason. I added a new string "message_last_edited_by" and did the formatting. It worked.

[mahibi]

I could not perform string formatting on the string "nc_edited_by" (modified its value to "Edited by %1$s") for some reason. I added a new string "message_last_edited_by" and did the formatting. It worked.

I guess that could be because of already translated strings that don't contain %1$s. Did you use some other language for testing? Because of this it's a good idea to use a new key :+1:

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	81	81
Errors	10	10

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	8	8
Dodgy code	110	110
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	137	137

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3743-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[mahibi]

/backport to stable-19.0

[rakekniven]

Context question: What does "Clear Edit Button" mean? @mahibi

[sowjanyakch]

It is the content description of the view "X".

[rakekniven]

It is the content description of the view "X".

My proposal would be "Close edit button". Clearing means emtying something. Does that makes sense?

[AndyScherzinger]

/backport to stable-18.1

[sowjanyakch]

Clicking on the button "X", clears the text in the message field (edited text) and closes the edit view. It is like canceling the edit. Clicking on the button :heavy_check_mark: saves the edited text and closes the edit view.

[github-actions[bot]]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!