Implemented Google EmojiPicker

[Smarshal21]

Resolves #2735

Description:

This pull request is aimed at replacing the existing Vanniktech Emoji Picker with the Google EmojiPicker within our application. The primary objectives of this change are to enhance the user experience and maintain compatibility with current emoji standards and features.

Changes Made:

• Removed the Vanniktech Emoji Picker integration from the application.
• Integrated the Google EmojiPicker into the application.
• Ensured that all relevant functionality remains consistent after the replacement.

Screenshots:

🏁 Checklist

• [x] ⛑️ Tests (unit and/or integration) are included or not needed.
• [x] 🔖 Capability is checked or not needed.
• [x] 🔙 Backport requests are created or not needed: /backport to stable-xx.x.
• [x] 📅 Milestone is set.
• [x] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?).

[Smarshal21]

@mahibi and @AndyScherzinger could you please look into this pr and let me know and there are some usecases of vanniktech library which cant be replace with emoji2 library so i haven't changed them

[AndyScherzinger]

@Smarshal21 Afaik the former solution also allowed to search for emojis (not too important to have IMHO). Is this possible with the Google lib?

[Smarshal21]

Afaik

Afaik No, If yes will take a look at it but didn't find it in this LIb

[rapterjet2004]

ctrl + shift + r shows that there are still more instances of com.vanniktech.emoji in the project.

[Smarshal21]

`ctrl` + `shift` + `r` shows that there are still more instances of `com.vanniktech.emoji` in the project.

yeah here are some usecases of vanniktech library which cant be replaced with emoji2 library so i haven't changed them, should i remove every instance of vanniktech??

[rapterjet2004]

I think you should. These usages were created to support the implementation of the Vanniktech Emoji Picker. It doesn't make sense to continue to have them with the Emoji Picker being removed. But make sure to double check that those components still work without the Vanniktech libraries.

[Smarshal21]

I think you should. These usages were created to support the implementation of the Vanniktech Emoji Picker. It doesn't make sense to continue to have them with the Emoji Picker being removed. But make sure to double check that those components still work without the Vanniktech libraries.

Sure Will do it

[Smarshal21]

@rapterjet2004 could you let me know if the remaining instances of vanniktech are useful/important i find its to better to remove those as i dont find any usecases of it correct me if am wrong

[mahibi]

The goal is to remove the vanniktech lib completely. So you could just remove it from build.gradle and try to implement everything with the google lib instead.

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	83	84
Errors	8	8

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	8	8
Dodgy code	112	112
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	139	139

Lint increased!

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3439-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[Smarshal21]

@mahibi @rapterjet2004 resolved the changes requested👍🏻

[mahibi]

@mahibi @rapterjet2004 resolved the changes requested👍🏻

thank you @Smarshal21 and sorry for delayed feedback.

As far as is see the toggle when clicking on the emoji icon is still different now. I would like to preserve the behaviour that a keyboard (R.drawable.ic_baseline_keyboard_24) or the emoji icon is shown left to the message input, depending on the state. And clicking on it should switch between the emoji view and keyboard.

[Smarshal21]

@mahibi @rapterjet2004 resolved the changes requested👍🏻

thank you @Smarshal21 and sorry for delayed feedback.

As far as is see the toggle when clicking on the emoji icon is still different now. I would like to preserve the behaviour that a keyboard (R.drawable.ic_baseline_keyboard_24) or the emoji icon is shown left to the message input, depending on the state. And clicking on it should switch between the emoji view and keyboard.

as far as i see its working fine i can toggle between them.

[github-actions[bot]]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!