talk-android
talk-android copied to clipboard
Ability to Bubble Conversations
- fixes #3384
🚧 TODO
- [x] Bubble Works
- [x] Enabled when conversation is marked is important
- [ ] Use Conversation Avatar for bubble icon -_- no idea why this isn't working
- [x] Multiple bubbles for multiple conversations
- [ ] Embedded view doesn't work
- [x] Error with multiple marked important conversations
🏁 Checklist
- [ ] ⛑️ Tests (unit and/or integration) are included or not needed
- [ ] 🔖 Capability is checked or not needed
- [ ] 🔙 Backport requests are created or not needed:
/backport to stable-xx.x
- [ ] 📅 Milestone is set
- [ ] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)
Codacy
Lint
Type | master | PR |
Warnings | 89 | 89 |
Errors | 0 | 0 |
SpotBugs
Category | Base | New |
---|---|---|
Bad practice | 6 | 6 |
Correctness | 10 | 10 |
Dodgy code | 123 | 123 |
Internationalization | 5 | 5 |
Malicious code vulnerability | 3 | 3 |
Performance | 8 | 8 |
Security | 2 | 2 |
Total | 157 | 157 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3399-talk.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!