talk-android icon indicating copy to clipboard operation
talk-android copied to clipboard

replace emojipicker

Open mahibi opened this issue 2 years ago • 8 comments

Android now offers an Emojipicker (currently alpha): https://developer.android.com/jetpack/androidx/releases/emoji2#emojipicker-1.0.0-alpha01

As we have some problems with https://github.com/vanniktech/Emoji

the picker might be replaced.

  • [ ] wait for stable release & try out

mahibi avatar Feb 02 '23 10:02 mahibi

Looks like Stable version is now out https://developer.android.com/jetpack/androidx/releases/emoji2#1.3.0

AndyXheli avatar Apr 12 '23 18:04 AndyXheli

As far as i see the emojipicker will only be included since v1.4.0 which is still beta: https://developer.android.com/jetpack/androidx/releases/emoji2#1.4.0-beta01

mahibi avatar Apr 17 '23 12:04 mahibi

Ahh okay sorry I thought it was also on version 1.3.0

AndyXheli avatar Apr 17 '23 12:04 AndyXheli

i want to work on this could you please assign this to me

Smarshal21 avatar Aug 24 '23 08:08 Smarshal21

i want to work on this could you please assign this to me

the emojipicker from google is still in alpha state. Usually we avoid using alpha state libs so i suggest to wait a bit longer.

mahibi avatar Aug 25 '23 07:08 mahibi

Sure

On Fri, 25 Aug 2023, 1:04 pm Marcel Hibbe, @.***> wrote:

i want to work on this could you please assign this to me

the emojipicker from google is still in alpha state. Usually we avoid using alpha state libs so i suggest to wait a bit longer.

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/talk-android/issues/2735#issuecomment-1692906264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXYPUKGMJTB5J346L5V5GT3XXBIR7ANCNFSM6AAAAAAUO2G5IY . You are receiving this because you commented.Message ID: @.***>

Smarshal21 avatar Aug 25 '23 07:08 Smarshal21

It seems that emojipicker was released with emoji2 v1.4.0

https://developer.android.com/jetpack/androidx/releases/emoji2#version_14_2 https://developer.android.com/develop/ui/views/text-and-emoji/emoji-picker

If you are still interested, feel free to give it a try @Smarshal21

mahibi avatar Sep 27 '23 08:09 mahibi

i implemented it here - https://github.com/nextcloud/talk-android/pull/3439

Smarshal21 avatar Nov 08 '23 19:11 Smarshal21