talk-android
talk-android copied to clipboard
[WIP] remove code that is unused
Lint
| Type | master | PR |
| Warnings | 112 | 112 |
| Errors | 1 | 1 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 4 |
| Correctness Warnings | 33 |
| Experimental Warnings | 2 |
| Internationalization Warnings | 9 |
| Malicious code vulnerability Warnings | 10 |
| Performance Warnings | 21 |
| Security Warnings | 2 |
| Dodgy code Warnings | 54 |
| Total | 135 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 4 |
| Correctness Warnings | 33 |
| Experimental Warnings | 2 |
| Internationalization Warnings | 9 |
| Malicious code vulnerability Warnings | 10 |
| Performance Warnings | 22 |
| Security Warnings | 2 |
| Dodgy code Warnings | 54 |
| Total | 136 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2462-talk.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.
Codacy
Lint
| Type | master | PR |
| Warnings | 112 | 113 |
| Errors | 1 | 1 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 4 | 4 |
| Correctness | 75 | 73 |
| Dodgy code | 315 | 308 |
| Experimental | 2 | 2 |
| Internationalization | 9 | 9 |
| Malicious code vulnerability | 54 | 54 |
| Performance | 22 | 21 |
| Security | 2 | 2 |
| Total | 483 | 473 |
Lint increased!
i changed this to draft. this PR itself makes sense but in the next days i might change a lot in this class so this PR might be obsolete soon..