replace photo camera code with intent to open system camera

[mahibi]

With https://github.com/nextcloud/talk-android/pull/2351 we introduced the possibility to record a video directly from the attachments menu.

For photos this is already possible as there is an own implemented camera. However we would like to replace that code with an intent based solution like it's done for the videorecording.

If there are any reasons against this, it can be discussed in this issue. Otherwise we might replace the feature in the future..

Also pinging @ASerbinski to let you know, as you contributed code to the TakePhotoActivity..

[ASerbinski]

This actually sounds like a great idea.

The contributions I made helped a bit with some of the most obvious problems with the built in camera, which still falls dramatically short of what could be available through the system camera. Pixel phones in particular do NOT expose advanced features through CameraX extensions, which means that we would never be able to take advantage of advanced capabilities like night sight or portrait mode.

Concerns I have are;

1. to ensure that the system camera does NOT store a copy of the file on the local filesystem (this may not be an issue, but I don't know how the system camera will work in this application),
2. system camera defaults to maximum resolution and does not make it trivial to switch to a lower resolution for sending on a slow network.

[mahibi]

thanks to share your thoughts :+1:

1. to ensure that the system camera does NOT store a copy of the file on the local filesystem (this may not be an issue, but I don't know how the system camera will work in this application),

good point. i will keep this issue open to give others the chance to share their thoughts on this..

2. system camera defaults to maximum resolution and does not make it trivial to switch to a lower resolution for sending on a slow network.

So this should be solved by us to add options to modify the size..