Set minSdkVersion to 23 (Android 6) II

[timkrueger]

Because of updating the minSdkVersion to 23 it comes to some obscure UI freezes when using frescos 'RoundPostprocessor#process' to round avatar bitmaps. So the function 'DisplayUtils#roundBitmap' is adopted from Nextcloud Files for Android.

• [ ] Create issue in android library to move solution from Talk and Files
  • https://github.com/nextcloud/android/commit/e288a4425cff9ff035e97353f73025a4a62f16a5#diff-1f8fbff5ab5e48d3d0dc4138be0149a949e8851669092a876e3600155b751f6c

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2449-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[timkrueger]

I have problems to set the correct icon for the current user in the search bar of the ConversationListController. Actually the icon is always blue:

This is the new way with Coil where I try to load the icon:

https://github.com/nextcloud/talk-android/blob/2ea3a2882c26fff158623057ef22f2996c319e17/app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.kt#L213-L263

Has somebody an idea whats going wrong?

//cc @AlvaroBrey, @mahibi

[mahibi]

after switching to light/dark theme, the avatars in conversation list are gone. (after that: when i enter a conversation and go back again, they are visible again)

[mahibi]

• user status rendering broken in conversation list

same here

• inline reply in notification has endless spinner on hitting reply button

for me the send button disappears when hitting it, but the notification with edited text remains. And when i go back to the app, it's frozen! At the moment when i hit reply button in notification, the log contains the error "E/AudioAttributes: Invalid stream type -1 for AudioAttributes" ...

[mahibi]

when i change the own avatar in the settings, it still displays the old avatar in the app, while on web there is the new avatar.

[mahibi]

• [x] checks with Build.VERSION.SDK_INT < Build.VERSION_CODES.M can be removed

[timkrueger]

I have one last issue at this point and I don't get it.

If you switch the theme ( regardless from light to dark, dark to light, in Talk or system settings) the avatars in the conversation list are gone:

If you run the app in debug, Coil will write logs. It looks like the the image loading actions will be canceled in the case of a theme switch:

2022-12-05 14:29:02.705 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🏗  Cancelled - https://cloud.example.com/index.php/avatar/tim2/512
2022-12-05 14:29:02.729 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🏗  Cancelled - android.graphics.drawable.LayerDrawable@f9c79c1
2022-12-05 14:29:02.734 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🏗  Cancelled - android.graphics.drawable.LayerDrawable@d4cf954
2022-12-05 14:29:02.773 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🏗  Cancelled - android.graphics.drawable.LayerDrawable@a2e8ed9
2022-12-05 14:29:02.826 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🏗  Cancelled - android.graphics.drawable.LayerDrawable@43d1af1
2022-12-05 14:29:02.843 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🏗  Cancelled - android.graphics.drawable.LayerDrawable@8d00a47
2022-12-05 14:29:02.858 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🏗  Cancelled - android.graphics.drawable.LayerDrawable@9b0e0d
2022-12-05 14:29:02.876 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🏗  Cancelled - android.graphics.drawable.LayerDrawable@9be2fc3

In comparison the successful loading (during switching back to the list from a single conversation):

2022-12-05 14:26:41.972 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🧠 Successful (MEMORY) - android.graphics.drawable.LayerDrawable@2987616
2022-12-05 14:26:41.973 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🧠 Successful (MEMORY) - android.graphics.drawable.LayerDrawable@9e92b97
2022-12-05 14:26:41.973 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🧠 Successful (MEMORY) - android.graphics.drawable.LayerDrawable@159c184
2022-12-05 14:26:41.973 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🧠 Successful (MEMORY) - android.graphics.drawable.LayerDrawable@c45cd6d
2022-12-05 14:26:41.973 30511-30511 RealImageLoader         com.nextcloud.talk2                  I  🧠 Successful (MEMORY) - android.graphics.drawable.LayerDrawable@d9ddda2

Would appreciate ideas, suggestions or even a little bit pair programming.

[AndyScherzinger]

@timkrueger can you rebase and resolve the conflicts, then I'll check it out.

[timkrueger]

@timkrueger can you rebase and resolve the conflicts, then I'll check it out.

Done.

//cc @mahibi

[timkrueger]

/rebase

[AndyScherzinger]

@timkrueger is app/src/main/java/third/parties/fresco/BetterImageSpan.kt still needed?

[timkrueger]

@timkrueger is app/src/main/java/third/parties/fresco/BetterImageSpan.kt still needed?

Still needed at this point. Did not want to tackle the topic as well. Everything was already big enough. But in the future, the part should disappear.

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	112	112
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	4	4
Correctness	29	28
Dodgy code	250	233
Experimental	2	2
Internationalization	6	6
Malicious code vulnerability	53	47
Performance	21	21
Security	2	2
Total	367	343

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2449-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.