nextcloud
Feature/1724/missed call notification
Lint
| Type | master | PR |
| Warnings | 112 | 112 |
| Errors | 1 | 1 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 4 |
| Correctness Warnings | 33 |
| Experimental Warnings | 2 |
| Internationalization Warnings | 9 |
| Malicious code vulnerability Warnings | 10 |
| Performance Warnings | 22 |
| Security Warnings | 2 |
| Dodgy code Warnings | 54 |
| Total | 136 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 4 |
| Correctness Warnings | 33 |
| Experimental Warnings | 2 |
| Internationalization Warnings | 9 |
| Malicious code vulnerability Warnings | 10 |
| Performance Warnings | 22 |
| Security Warnings | 2 |
| Dodgy code Warnings | 54 |
| Total | 136 |
Codacy
Lint
| Type | master | PR |
| Warnings | 112 | 112 |
| Errors | 1 | 1 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 4 | 4 |
| Correctness | 75 | 68 |
| Dodgy code | 315 | 272 |
| Experimental | 2 | 2 |
| Internationalization | 9 | 7 |
| Malicious code vulnerability | 53 | 53 |
| Performance | 23 | 22 |
| Security | 2 | 2 |
| Total | 483 | 430 |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2415-talk.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.
detekt checks are not fully satisfied. Some of the checks fail with ComplexMethod. While this is true and should be resolved in general, i suggest to review/merge anyway because this PR already changed a lot and seems stable for me. Further refactoring might take place in follow up PR's (after my vacation or later).
feel free to improve minor things in this PR while reviewing @timkrueger
The new notifications works as expected. But for the debug information I got a negative delay:
i reverted the calculation of the delivery time. This doesn't make sense because time is not synchronized... in the future we may be able to trigger a test push from the device itself and measure the full roundtrip time until it is received on the device again. But calculating a difference to a timestamp from firebease server doesn't make sense because it's not time-synchronized and never will be.
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2415-talk.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.