duplicated messages in chat after call

[mahibi]

Steps to reproduce

1. start a call & hangup
2. BUG: system messages in chat are shown multiple times (3x?)
3. write a message
4. BUG: message shown twice
5. go back to conversation list & re enter chat
6. BUG: system messages in chat are shown multiple times (2x?), just like on server! (see screenshot)
7. written message is shown once

Expected behaviour

Actual behaviour

the call system messages are shown multiple times. after the call also the normal messages are shown twice

right after trying to call someone

after switching to conversation list and back to chat

also on server the call system messages are shown twice:

Device information

Device: Xiaomi Redmi Note 7

Talk version: 14.1.0 alpha 06

Server information

Sermo

[mahibi]

might be related: https://github.com/nextcloud/talk-android/issues/684 https://github.com/nextcloud/talk-android/issues/453

[hboetes]

I've seen this as well. Or messages not being displayed until I reopen the window (select another chat and then come back)

[isaiah-v]

I'm seeing this too.

[miaulalala]

Seeing this on the Android app.

[AndyXheli]

I also get them without being on a call and sometimes new messages that i send are not visible i have to go out of the chat and back in

[mahibi]

This was most likely caused with https://github.com/nextcloud/talk-android/pull/1766/files when the wasDetached handling was removed. When i delete the lines

if (inConversation) {
    Log.d(TAG, "execute joinRoomWithPassword in onAttach")
    joinRoomWithPassword()
}

in onAttach it's fixed, but surely will add other bugs. (this also fixes https://github.com/nextcloud/talk-android/issues/2171) So just need to find more time now to look into this.