talk-android icon indicating copy to clipboard operation
talk-android copied to clipboard

add WebAuthn support using hwsecurity-fido2

Open dschuermann opened this issue 4 years ago • 7 comments

Adds WebAuthn support like in https://github.com/nextcloud/android/pull/6395

Updates hwsecurity to 4.2.1. The latest 4.4.0 artifact is somehow not available on Jitpack. I just wrote the Jitpack support...

Signed-off-by: Dominik Schürmann [email protected]

dschuermann avatar Apr 30 '21 12:04 dschuermann

Lint

TypemasterPR
Warnings369369
Errors33

SpotBugs (new)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 162
Experimental Warnings 2
Internationalization Warnings 8
Performance Warnings 44
Security Warnings 7
Dodgy code Warnings 254
Total 489

SpotBugs (master)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 162
Experimental Warnings 2
Internationalization Warnings 8
Performance Warnings 44
Security Warnings 7
Dodgy code Warnings 254
Total 489

nextcloud-android-bot avatar Apr 30 '21 12:04 nextcloud-android-bot

@tobiasKaminsky could you test this, since you are having a hardware key? 😃

AndyScherzinger avatar Apr 30 '21 15:04 AndyScherzinger

I use a yubikey, and as soon as I plug it in my Nokia device asks met to grant access. But when choosing "webauthn device" during login, I shortly see the info "plug in your device" (or similar), but nothing happens. I connect yubikey via usb, so I cannot see any logcat output…

tobiasKaminsky avatar May 03 '21 06:05 tobiasKaminsky

I use a yubikey, and as soon as I plug it in my Nokia device asks met to grant access. But when choosing "webauthn device" during login, I shortly see the info "plug in your device" (or similar), but nothing happens. I connect yubikey via usb, so I cannot see any logcat output…

@dschuermann any ideas regarding @tobiasKaminsky issue with the upgrade test? ❤️

AndyScherzinger avatar May 11 '21 15:05 AndyScherzinger

pinging @dschuermann regarding https://github.com/nextcloud/talk-android/pull/1206#issuecomment-831053420

AndyScherzinger avatar Jul 09 '21 18:07 AndyScherzinger

pinging @dschuermann regarding https://github.com/nextcloud/talk-android/pull/1206#issuecomment-831053420

AndyScherzinger avatar Sep 05 '21 16:09 AndyScherzinger

Hello @dschuermann 👋

I know it's a long time ago that we reached out to you. Sorry for that 😕

It would be great to have WebAuthn support into into NC Talk for Android. If you're interested to get this in please let me now. I'm available to support you to getting that in.

timkrueger avatar Aug 15 '22 10:08 timkrueger