tables icon indicating copy to clipboard operation
tables copied to clipboard

Move to vite for bundling

Open juliushaertl opened this issue 6 months ago • 11 comments

  • Introduce vite for building
  • Bump @nextcloud/vue
  • Bump @nextcloud/dialogs and @nextcloud/files
  • Adjust code to changes in libraries
  • [x] Drop 26 suppport as there is no support for javascript modules that are required by vite https://github.com/nextcloud/tables/pull/1179

juliushaertl avatar Feb 08 '24 16:02 juliushaertl

@juliushaertl You say "based on https://github.com/nextcloud/tables/pull/647", but I don't see how?

enjeck avatar Feb 09 '24 07:02 enjeck

I based my branch locally on top of yours and then created a pull request towards that one. You can also sett that in the github ui:

Screenshot 2024-02-09 at 09 22 56

Once your PR/branch gets merged github automatically changes this, but that way I can make use of your changes already during development.

juliushaertl avatar Feb 09 '24 08:02 juliushaertl

Doesn't work for me after running npm ci and then npm run dev. Am I missing something?

enjeck avatar Feb 09 '24 10:02 enjeck

Sorry, it isn't ready yet, didn't wanted to ask for review but the ones got autoassigned by github 🙈 I'll ping you once I'm ready :)

juliushaertl avatar Feb 09 '24 11:02 juliushaertl

I also noticed that tables have dark favicons for me now:

Just tried with current main with the same result. So not related to this PR.

max-nextcloud avatar Feb 13 '24 10:02 max-nextcloud

Likely caused by https://github.com/nextcloud/tables/pull/712 then

juliushaertl avatar Feb 13 '24 14:02 juliushaertl

We need to decide when to merge this, currently the vite build requires https://github.com/nextcloud/server/pull/36057 which is 27 only.

juliushaertl avatar Feb 13 '24 14:02 juliushaertl

@susnux I'm having some trouble here with the npm run watch command which always exits after the first build. Is that something you've seen already? Any clue why that might happen? We just call vite --mode development build --watch

juliushaertl avatar Feb 14 '24 07:02 juliushaertl

@susnux I'm having some trouble here with the npm run watch command which always exits after the first build.

Should be fixed now: https://github.com/vitejs/vite/issues/15951

susnux avatar Mar 12 '24 16:03 susnux