tables icon indicating copy to clipboard operation
tables copied to clipboard

feat: Use simple input field instead of multiselect for plain URLs

Open juliushaertl opened this issue 7 months ago • 5 comments

When no link provider (except URL) is enabled a multiselect field might be confusing to users, so this PR switches over to a simple input field in that case.

Screenshot 2024-01-19 at 17 41 12

juliushaertl avatar Jan 19 '24 16:01 juliushaertl

Weird that the test still fails on some stable branches :thinking:

enjeck avatar Jan 21 '24 20:01 enjeck

How to reproduce this? I removed the provider stuff directly on db side like [{"columnId":1001,"value":"http://phpmyadmin.local"}] but there is no change on the front end?!

Thoughts:

  • Is it possible to look for other resources if it is a plain url presented as a input?
  • Wouldn't it be better if we change plain URLs to link providder URL and fetch the title from the url as title or subline?

datenangebot avatar Jan 22 '24 07:01 datenangebot

Sorry I should have described this a bit more. The goal of this PR is purely to make the input more user friendly if only URL is enabled as a provider for a column, as in this case the multiselect does not give any benefit as there is only one option to select (which is inserting the plain URL).

I agree we should still fetch the title and store/render it for additional context. Will look into that.

juliushaertl avatar Jan 22 '24 08:01 juliushaertl