tables
tables copied to clipboard
enh: Delete Application and its shares
Fixes #991
Need to check/fix some edge cases:
- [x] Delete shares from a newly-created context without reload
- [x] Delete shares from a context whose shares were updated
- [x] check that transfer context works. Not related to this, but caught a bug https://github.com/nextcloud/tables/issues/1046
- [x] check that shared resources are removed when context is deleted
@blizzz How can I fix the Static Analysis errors here?
@blizzz How can I fix the Static Analysis errors here?
Ah, leftovers from my changes. I added a parameter to ContextService, but changed name and type during working on it. Alas not everywhere. So it's fixing, fix-upping the original commit, and rebasing with squashing it.
Done and rebased.
/backport to stable0.7
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!