spreed
spreed copied to clipboard
Join call / leave call sound is played for internal clients
- Start a call in Chrome
- Start recording
- When the internal participant (= the recording client) joins, the joining sound is played
Expected: Internal clients are already hidden in the participant view and should therefore not generate a joining / leaving sound.
Hmm :/
The internal client is also used for SIP users that dial in via phone. Are they distinguishable @danxuliu ?
Hmm… so SIP participants should actually be shown in the call view, right? Regarding https://github.com/nextcloud/talk-ios/pull/1094
If I am not mistaken one thing is the SIP bridge, which uses an internal client and is therefore hidden (also in the web UI since SIP was introduced), and another thing are the SIP participants, which use a virtual session and work like other participants, except in how their flags are updated.
Expected: Internal clients are already hidden in the participant view and should therefore not generate a joining / leaving sound.
Still not sure about this. I think it's fine, but I would play another sound which clearly indicates the recording
but I would play another sound which clearly indicates the recording
I think that would be a good solution to this.