spreed icon indicating copy to clipboard operation
spreed copied to clipboard

Join call / leave call sound is played for internal clients

Open SystemKeeper opened this issue 2 years ago • 5 comments

  1. Start a call in Chrome
  2. Start recording
  3. When the internal participant (= the recording client) joins, the joining sound is played

Expected: Internal clients are already hidden in the participant view and should therefore not generate a joining / leaving sound.

SystemKeeper avatar Feb 24 '23 14:02 SystemKeeper

Hmm :/

The internal client is also used for SIP users that dial in via phone. Are they distinguishable @danxuliu ?

nickvergessen avatar Feb 24 '23 16:02 nickvergessen

Hmm… so SIP participants should actually be shown in the call view, right? Regarding https://github.com/nextcloud/talk-ios/pull/1094

SystemKeeper avatar Feb 24 '23 16:02 SystemKeeper

If I am not mistaken one thing is the SIP bridge, which uses an internal client and is therefore hidden (also in the web UI since SIP was introduced), and another thing are the SIP participants, which use a virtual session and work like other participants, except in how their flags are updated.

danxuliu avatar Feb 24 '23 16:02 danxuliu

Expected: Internal clients are already hidden in the participant view and should therefore not generate a joining / leaving sound.

Still not sure about this. I think it's fine, but I would play another sound which clearly indicates the recording

nickvergessen avatar Nov 21 '23 08:11 nickvergessen

but I would play another sound which clearly indicates the recording

I think that would be a good solution to this.

SystemKeeper avatar Nov 21 '23 09:11 SystemKeeper