spreed icon indicating copy to clipboard operation
spreed copied to clipboard

Check overwritten CSS rules

Open nickvergessen opened this issue 3 years ago • 3 comments

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Since the Vue 7 update was made and a lot of issues were solved by simply removing CSS blocks which we had overwriting component stuff we should make a trip through all of them and see what we should do with them:

  • ❌ Remove
  • 🆙 Upstream
  • ⏯️ Keep

nickvergessen avatar Sep 01 '22 15:09 nickvergessen

Especially v-deeps should be checked (see #2623 ) but not only.

nickvergessen avatar Sep 01 '22 15:09 nickvergessen

  • Should be checked again after #10626
  • Including :deep styles, and classes applied on <Nc... components (see EmptyContent discussion above)

Antreesy avatar Oct 04 '23 08:10 Antreesy

  • NcAppContent
    • custom styles in a call
  • NcEmptyContent - many places
  • NcRichContentEditable
    • MentionBubble on RTL
    • Emoji button support
  • NcAvatar
    • AvatarWrapper
    • and other places
  • NcActions
    • custom styling in MessageButtonBar
    • NcActionButton with danger style in Conversation.vue menu
  • Dialogs and Modals in many places
  • NcSettingdDialog - ConversationSettings
  • NcSelect - MediaDeviceSelector width: 100%
  • NcCheckboxRadioSwitch - MediaSettings - checkbox-radio-switch__label in focus in warning
  • NcListItem - some custom styling in participants
  • NcAppSidebar - many custom styles
  • NcButton
    • CallTime
    • LeftSidebar - .invitation-button
  • Fields
    • SearchBox
    • TurnServer in error state

ShGKme avatar Aug 07 '24 12:08 ShGKme

I think it is cleared out mostly. We introduced TOREMOVE flag so we can mark the things to remove and roughly when

DorraJaouad avatar Oct 09 '25 12:10 DorraJaouad