spreed icon indicating copy to clipboard operation
spreed copied to clipboard

Custom background image for own video in calls

Open AndyScherzinger opened this issue 3 years ago • 6 comments

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe. In Talk it is currently possible to blur the background of the video being sent. However it is not possible at the moment to replace the background with a custom image instead.

Describe the solution you'd like Note that replacing the background with a custom image is already supported by the code that blurs the background; what is missing is a UI to select the custom image (and of course adjusting the code to use the selected image).

The feature are two ways two support that and both should be present in the end, while there is no strict order

  1. select an image from you Nextcloud account or upload one to you Nextcloud account to then be used (the later being an additional step to the first one
  2. select an image from a predefined, talk-shipped set of background images, best to ask @jancborchardt and @nimishavijay for potential background images, usually it is nature/landscape, office and "funny" background images like space or colored balls.

Describe alternatives you've considered none that I am aware of except using the blur option

Additional context

AndyScherzinger avatar Jul 23 '22 11:07 AndyScherzinger

Shipped backgrounds have the advantage we can put them into the img/ folder of the app and use them directly.

Uploaded items mean we need a public accessible endpoint which allows to access the image without any permission checks, etc. This has a lot of potential for security risks.

nickvergessen avatar Jul 23 '22 11:07 nickvergessen

Wouldn't you need to know the exact image name and be a participant in the call/room at least?

AndyScherzinger avatar Jul 23 '22 11:07 AndyScherzinger

Again as stated there is no particular order, so starting with a fixed and shipped set as step one is just fine.

AndyScherzinger avatar Jul 23 '22 11:07 AndyScherzinger

Note that the composition of the background image and the video is locally done in the browser of the sender participant. Other participants just receive the final video, they do not need access to the background image. Therefore the endpoint would need to be accessed only by the same participant that uploaded the image.

danxuliu avatar Jul 24 '22 20:07 danxuliu

For simplicity, the default images could be the ones we already ship with Dashboard (some make more sense, some less though).

Or what kinds of images would be expected there? Stock office and home working backgrounds – maybe we need to do a photoshoot? ;)

jancborchardt avatar Aug 02 '22 15:08 jancborchardt

For simplicity, the default images could be the ones we already ship with Dashboard (some make more sense, some less though).

Since dashboard can be disabled we would duplicate them to talk.

Or what kinds of images would be expected there?

I would suggest:

  • Office
  • Home-Office
  • Nature
  • Cinema/Theater
  • something (board) gaming related

nickvergessen avatar Aug 02 '22 15:08 nickvergessen

1st design pass done, feedback welcome. @jancborchardt @nimishavijay @nickvergessen Please note that the first 3 buttons in the background editor need to be designed, but they will likely be an icon + label. Will need something more complex for the custom one.

Screenshot 2023-04-05 at 16 41 43

marcoambrosini avatar Apr 05 '23 15:04 marcoambrosini

Ok I think I came up with a much better design for this that's way more tidy and much easier to read/scan

Screenshot 2023-04-10 at 14 47 46

cc again @nimishavijay and @jancborchardt for feedback

marcoambrosini avatar Apr 10 '23 14:04 marcoambrosini

moving design comments to #9251 as requested by @nickvergessen

marcoambrosini avatar Apr 10 '23 15:04 marcoambrosini