nextcloud
Improve Talk HPB validation check by checking the shared secret
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
When configuring the Talk HPB in the Talk admin settings, a check is performed on the user-entered parameters. The check doesn't take into account the shared secret as it just runs a request to the api/v1/welcome endpoint, that doesn't require authentication. This can be misleading as the connection will fail with a wrong shared secret.
Describe the solution you'd like Let the Talk HPB validation check to take into account the shared secret as well.
Describe alternatives you've considered
Additional context
Copied from https://github.com/nextcloud/spreed/pull/7504
Would it be possible to automatically reset the bruteforce attempts when a new secret is set? The IP address to reset could be resolved from the domain of the configured HPB server. I do not know if that could fail in some cases, though (for example if the HPB is in the same local network as the Nextcloud server and the requests were throttled using the local IP, but the domain of the configured HPB server resolves to the public IP).
Alternatively (or in addition to), maybe a message can be shown in the UI to reset the bruteforce attempts if the HPB requests are throttled. It could be done as part of https://github.com/nextcloud/spreed/issues/7164 too instead of now.
