spreed icon indicating copy to clipboard operation
spreed copied to clipboard
verified publisher icon nextcloud

Improve label of the audio button "No audio"

Open nickvergessen opened this issue 4 years ago • 6 comments

Currently the label of the audio button says "No audio" maybe we should change that to "No audio device selected" or something a like and clicking it could bring up the device checker?

(Something for a follow up thou)

Originally posted by @nickvergessen in https://github.com/nextcloud/spreed/issues/6604#issuecomment-978950745

nickvergessen avatar Nov 25 '21 08:11 nickvergessen

Hi, could I work on this?

anniemichel avatar Sep 13 '22 19:09 anniemichel

Sure. Do you need more pointers to the code?

nickvergessen avatar Sep 13 '22 19:09 nickvergessen

Yeah, that would be great. Thank you!

anniemichel avatar Sep 13 '22 21:09 anniemichel

Code should be here: https://github.com/nextcloud/spreed/blob/02e83a61dc246c3130a6ed8bd2e969996b96d0b8/src/components/CallView/shared/LocalMediaControls.vue#L389-L419

Not sure how to trigger the device checker from there thou

nickvergessen avatar Sep 14 '22 07:09 nickvergessen

Thank you! Would you be able to advise me in how I should go about setting up the development environment? I see that I need to install a Nextcloud server in order to clone the repo, but I'm confused about how to do that on MacOS. Do I sign up at a provider and install a server through Nextcloud's website, or do I need to follow a different development setup?

anniemichel avatar Sep 18 '22 18:09 anniemichel

I'd recommend to use https://github.com/juliushaertl/nextcloud-docker-dev

nickvergessen avatar Sep 18 '22 19:09 nickvergessen