spreed icon indicating copy to clipboard operation
spreed copied to clipboard

Talk dashboard follow up

Open DorraJaouad opened this issue 7 months ago • 19 comments

Issue 1 (unread mentions with counter or without) : The counter is unread mentions can convey that the number is actually the total of unread mentions and not unread messages in total

Image

Suggestions: a- Show (@) instead of counter b- Show dot without a counter

Issue 2 (Buttons text are often ellipsized in german)

Image

Suggestions: instead of "Neue Unterhaltung erstellen" > both "Unterhaltung erstellen" or "Neue Unterhaltung" would work instead of "Offener Unterhaltung beitreten" > "Unterhaltung suchen" or "Bestehende Unterhaltungen" instead of "Eine Telefonnummer anrufen" > "Telefonnummer anrufen" OR instead of introducing new strings, should we just wrap them or collapse to actionsmenu

Issue 3 (Does it depend on compact mode?):

Image

When compact mode is enabled, currently there is no access to last messages, so unread mentions sections will always show "no messages" as a subline.

Suggestions:

  • Show subline regardless of compact mode state
  • Sustain the compact mode in Dashboard as well (for both upcoming reminders and unread mentions)

DorraJaouad avatar May 16 '25 15:05 DorraJaouad

Issue 2 (Buttons text are often ellipsized in german)

Image

Suggestions: instead of "Neue Unterhaltung erstellen" > both "Unterhaltung erstellen" or "Neue Unterhaltung" would work instead of "Offener Unterhaltung beitreten" > "Unterhaltung suchen" or "Bestehende Unterhaltungen" instead of "Eine Telefonnummer anrufen" > "Telefonnummer anrufen" OR instead of introducing new strings, should we just wrap them or collapse to actionsmenu

Wording doesn't solve the layout issue. There always is a language where some words are long, and on a small screen there is no place for even short words.

It should wrap to multi-line, or be scrollable.

Image

ShGKme avatar May 16 '25 15:05 ShGKme

Talk Icon on the "View conversation" button is too large and not aligned

Image

  • Fixed in nextcloud-vue

ShGKme avatar May 16 '25 15:05 ShGKme

In the "Unread mentions" list, the title is not truncated

ShGKme avatar May 16 '25 15:05 ShGKme

"Upcoming meetings" buttons are not available via keyboard navigation and on mobile devices

ShGKme avatar May 16 '25 15:05 ShGKme

Maybe nextcloud-vue problem, but the text on the navigation overlaps text on the dashboard, which is not readable for accessibility

Image

ShGKme avatar May 16 '25 15:05 ShGKme

"Upcoming meetings" buttons are not available via keyboard navigation and on mobile devices

Proposal: make the conversation name in the card a link

ShGKme avatar May 16 '25 15:05 ShGKme

A11y nitpicks:

  • "Upcoming meetings" and other titles should be headers
  • "Upcoming meetings" cards should be a list, labelled by the heading via aria-labelledby
    • The same for other lists
  • Would be nice to have the event title also as a real heading element
  • Scrolling button might need to be connected to the list, otherwise it isn't clear what they "scroll"
    • But I'm unsure, in which way...
  • Colored circle in the event card should have a visually heading text, explaining its meaning. Maybe also a title for all users

ShGKme avatar May 16 '25 15:05 ShGKme

Event cards have fixed height: 225px; even when the card content is empty/very full, or the screen is large/small.

ShGKme avatar May 16 '25 15:05 ShGKme

Personal preferencies: I'd prefer these buttons to be regular size. And aligned with the navigation Image

ShGKme avatar May 16 '25 15:05 ShGKme

The Home button has different padding on the left and right sides, which is quite visible. And secondary background on a semi-transparent navigation looks a bit low contrast. I'd try tertiary or primary.

Image

ShGKme avatar May 16 '25 15:05 ShGKme

The Home button has different padding on the left and right sides, which is quite visible. And secondary background on a semi-transparent navigation looks a bit low contrast. I'd try tertiary or primary.

Those are different paddings, one inter-element and one wrapping padding for the whole LS. They don't have to be equal

DorraJaouad avatar May 16 '25 15:05 DorraJaouad

Those are different paddings, one inter-element and one wrapping padding for the whole LS. They don't have to be equal

They don't. But it's quite visible to me since other paddings around this button are equal, there is no other horizontal padding in this bar (they are not visible with tertiary buttons), and the Home button is not couped with the search.

ShGKme avatar May 16 '25 15:05 ShGKme

instead of "Offener Unterhaltung beitreten" > "Unterhaltung suchen" or "Bestehende Unterhaltungen"

It should still refer to open conversations, as that is the feature it is about.

nickvergessen avatar May 19 '25 06:05 nickvergessen

The Home button has no label

Image

ShGKme avatar May 20 '25 07:05 ShGKme

Error while pushing the dashboard route: NavigationDuplicated: Avoided redundant navigation to current location: "/apps/spreed/".

This is spamed when clicking on the Home icon while being on the dashboard. While it is okay to not reload the UI, we should make sure it refreshes the content.

nickvergessen avatar May 22 '25 08:05 nickvergessen

Error while pushing the dashboard route: NavigationDuplicated: Avoided redundant navigation to current location: "/apps/spreed/".

I propose to change this for the entire router. It's almost never a problem to have duplicated navigation.

ShGKme avatar May 22 '25 09:05 ShGKme

Creating an instant meeting without a name results in --- roomName. Maybe something else is interferring, as I'm receiving the same name sometime on OCS_API_Viewer Image

Antreesy avatar May 23 '25 15:05 Antreesy

Yeah it's a legacy fall back intended for old clients. You can send "Meeting Date(LLL)" as fallback from the UI?

nickvergessen avatar May 23 '25 17:05 nickvergessen

You can send "Meeting Date(LLL)" as fallback from the UI?

Fallback right now is t('spreed', 'Meeting') in user's language

Antreesy avatar May 23 '25 18:05 Antreesy

Issue 3 (Does it depend on compact mode?): When compact mode is enabled, currently there is no access to last messages, so unread mentions sections will always show "no messages" as a subline.

I just wanted to report this as a bug. IMHO the compact mode for the conversation list should not impact the dashboard. There you usually have enough space and we are showing one line of text anyway, currently "no message" so it would not even need more space to show the actual message.

schiessle avatar Aug 14 '25 11:08 schiessle

I just wanted to report this as a bug. IMHO the compact mode for the conversation list should not impact the dashboard. There you usually have enough space and we are showing one line of text anyway, currently "no message" so it would not even need more space to show the actual message.

Agree, compact mode is meant to see more conversations in a view and not hide messages for privacy purposes. On the other hand, conversations that are sensitive (Where message is explicitly wanted to be hidden) should have a placeholder "sensitive information" like

DorraJaouad avatar Aug 14 '25 13:08 DorraJaouad

For general cases, IMO we should then roll back this line to always include lastMessage, even if not shown:

includeLastMessage: this.isCompact ? 0 : 1,

In the scope of 100+ users, and 5-10 people having this option on, I don't see it bringing some performance benefits opposed to negative side effects (now to think of, chat polling/blocks also rely on conversation last message)

Antreesy avatar Aug 14 '25 14:08 Antreesy