spreed icon indicating copy to clipboard operation
spreed copied to clipboard

fix(CallView): light improvement

Open DorraJaouad opened this issue 9 months ago • 4 comments

☑️ Resolves

  • Fix #10567
  • When joining a call in group conversation, it is set to grid view even for "connecting" view which makes the tile looks weird. I enforce a speaker view when connecting so to keep a consistent view for all joiners and to avoid having an expanded local video tile.
  • Stop following button lost restoring the previous view state because of some watchers enforcing the temporary view (speaker view). I omitted those as startPresentation already handles it.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • [ ] ...

🏁 Checklist

  • [x] 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • [ ] 🖥️ Tested with Desktop client or should not be risky for it
  • [x] 🖌️ Design was reviewed, approved or inspired by the design team
  • [x] ⛑️ Tests are included or not possible
  • [x] 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

DorraJaouad avatar May 07 '24 11:05 DorraJaouad

  1. On the call, start following somebody and open stripe
  2. Start screensharing from another participant
  3. Stop screensharing
  4. No you are on the grid view instead of the previous "Following + open stripe"

Is that expected?

Before it returned to the same state, you were before presentation.

ShGKme avatar May 08 '24 14:05 ShGKme

But I don't see any alternatives.

Hide an option, while there's nothing to place on grid?

Antreesy avatar May 08 '24 15:05 Antreesy

Not sure it is related, but caught an exception:

TypeError: Cannot read properties of null (reading 'attributes')
    at VueComponent.shouldShowPresenterOverlay

on this line

https://github.com/nextcloud/spreed/blob/79bd33fdcc5de6041f628e699694dd90baf68484/src/components/CallView/CallView.vue#L325

ShGKme avatar May 09 '24 13:05 ShGKme

TypeError: Cannot read properties of null (reading 'attributes') at VueComponent.shouldShowPresenterOverlay

This was unrelated, but fixed as it is involved in "light improvement" :p

DorraJaouad avatar May 09 '24 16:05 DorraJaouad