spreed icon indicating copy to clipboard operation
spreed copied to clipboard

polishing of sidebar in public view

Open szaimen opened this issue 11 months ago • 4 comments

just tested on nc29.0.0b1

  • [ ] The icons in system dark mode in the header look broken: image
  • [x] Also the sidebar toggle button does not seem to work... https://github.com/nextcloud/spreed/pull/12133

szaimen avatar Mar 11 '24 10:03 szaimen

Seems to be the Talk public share sidebar, cc @danxuliu

Pytal avatar Apr 16 '24 23:04 Pytal

Reopening as the icon color and file name color is still wrong if I see that correctly

nickvergessen avatar Apr 17 '24 08:04 nickvergessen

And just for the record, we need to adjust the used variable, not the content of the variable. it claims to be a button tertiary-on-primary, but it's not on primary, it's on the background. Might be non trivial to solve. Best is to check the color/variable used by the app list when you are logged in

nickvergessen avatar Apr 17 '24 08:04 nickvergessen

That's the result of applying tertiary-no-background. But I'm not sure it's consistent:

  • either both NcButton and NcActions here should have dark color on a dark theme
  • or file name and "Download" button should have white color

image

Antreesy avatar Apr 17 '24 11:04 Antreesy

should be fixed with: https://github.com/nextcloud/server/pull/46785

susnux avatar Jul 26 '24 16:07 susnux

correct color is btw: --color-background-plain-text

susnux avatar Jul 26 '24 16:07 susnux

Nein, that indeed fixes the file name, but not the button =/

image

It's Talk-only now, so I'll take over from here

Antreesy avatar Jul 26 '24 16:07 Antreesy