spreed icon indicating copy to clipboard operation
spreed copied to clipboard

Feat(MediaSettings): Add audio test

Open DorraJaouad opened this issue 1 year ago • 4 comments

☑️ Resolves

  • Fix #1181

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

Screencast :

https://github.com/nextcloud/spreed/assets/84044328/b213199f-0fbd-4396-874d-f31e154df71c

🚧 Tasks

  • [ ] Design review
  • [ ] Code review

🏁 Checklist

  • [ ] 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • [ ] 🖌️ Design was reviewed, approved or inspired by the design team
  • [ ] ⛑️ Tests are included or not possible
  • [ ] 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

DorraJaouad avatar Feb 21 '24 12:02 DorraJaouad

Audio Output: Add the "voice message" option on the media settings screen to allow recording and then playing back? Or a simple "bing" sound for testing?

I used something like bing sound for audio output testing. However, I can also add voice recording as a test for the mic. cc @nextcloud/designers @nickvergessen

DorraJaouad avatar Feb 21 '24 12:02 DorraJaouad

However, I can also add voice recording as a test for the mic.

Exactly that was the idea, it would basically allow you to test both, mic and speaker

nickvergessen avatar Feb 22 '24 13:02 nickvergessen

Exactly that was the idea, it would basically allow you to test both, mic and speaker

Right, but some users want just to test speaker and they don't want to randomly say some words XD . That's why I chose the first option. So add both or only voice recorder ?

DorraJaouad avatar Feb 22 '24 14:02 DorraJaouad

So add both or only voice recorder ?

I leave that to design cc @marcoambrosini

As for what to play, any issue with playing an already existing file (less files, more caching, less license issues, etc)

nickvergessen avatar Feb 22 '24 16:02 nickvergessen

@DorraJaouad @nickvergessen would it be possible to have a third entry with speaker selection similar to Jitsi? Or at least showing which is the current speaker?

marcoambrosini avatar Feb 26 '24 16:02 marcoambrosini

sinkId can show the audio output being used but read only and it is not supported on Safari.

Otherwise, selectAudioOutput allows user to select audio ouput device but it is only supported on Firefox.

DorraJaouad avatar Feb 27 '24 07:02 DorraJaouad

Or at least showing which is the current speaker?

navigator.mediaDevices.enumerateDevices() can list available output devices. Though we couldn't identify, which is being used by the browser (at best it shows Default). https://developer.mozilla.org/en-US/docs/Web/API/AudioContext is currently not implemented widely, so there's nothing to do atm.

navigator.mediaDevices.enumerateDevices().then((devices) => {
      devices.forEach((device) => {
        console.log(`${device.kind}: ${device.label} id = ${device.deviceId}`);
      });
    })

image

Antreesy avatar Mar 04 '24 10:03 Antreesy