✏️ Edit message - Overview

[nickvergessen]

Subtickets

• Request ticket: https://github.com/nextcloud/spreed/issues/1836
• [x] https://github.com/nextcloud/spreed/issues/11206
• [x] https://github.com/nextcloud/spreed/issues/11205
• [x] https://github.com/nextcloud/talk-ios/issues/1452
• [x] https://github.com/nextcloud/talk-android/issues/3509

---

MVP

• [ ] Edit in default input showing the original content as a "quote"
  • [ ] Don't allow changing from message to caption and vice-versa
  • [ ] Don't allow to toggle silent send on
• [ ] System message hidden like with delete?
• [ ] Visible indicator a message was edited (and by whom/when)?
  • [ ] Amend to the author name (edited) / (edited by moderator-name)
  • [ ] Editor+Time in Message menu as subline of timestamp
• [ ] Time limitation like for delete?
  • [ ] Limit editing to X hours (draft 24 hours, check what others do and discuss again)
  • [ ] Set the limit on deletion to infinite
• [ ] What to do about mention notifications (added a mention, removed a mention)?
  • [ ] Should indicate in the UI what happens (only when affected)
  • [ ] Make sure people don't get 1 for the message and 2 for followup edits
• [ ] What about bots?
  • [ ] Can not edit bot messages, moderators can
  • [ ] Bots will not get explicitly notified about previous edits (only with the default system message)?
  • [ ] If a message triggered a bot already it's yolo and will not be retriggered with the new content automatically (bot can do based on the system message?)
    • [ ] Should indicate in the UI what happens (only when affected)

Followups

• [ ] Revisions?
  • [ ] If so, also need to be able to delete/hide revisions (similarly to github) then to remove passwords

[SystemKeeper]

• Amend to the author name (edited) / (edited by moderator-name)

This could be tricky on phones, I can see that most of the time the moderator name will be truncated. Still okay or is wrapping mandatory in this case? (Wrapping the author label would be more work, at least on iOS).

Set the limit on deletion to infinite

That means deletion is always possible or editing a deleted message is always possible?

[Ivansss]

This could be tricky on phones, I can see that most of the time the moderator name will be truncated. Still okay or is wrapping mandatory in this case? (Wrapping the author label would be more work, at least on iOS).

Agree, we might need to find a better place for mobile devices.

That means deletion is always possible or editing a deleted message is always possible?

We will remove the limit to message deletion, so deleting a message will be always possible.

[SystemKeeper]

Agree, we might need to find a better place for mobile devices.

Maybe we could add a pencil to the message to indicate it was edited and show a „edited by/at“ when opening the context menu? (Thinking of phones here)

[SystemKeeper]

Some quick implementation on iOS.

Indicator in the chat (before/after the authors name):

Details when opening the context menu:

What do you think? :) CC @nextcloud/designers

[nickvergessen]

I think it looks good, but would prefer the icon after the name

[marcoambrosini]

I think that whenever there's space available, we should show the label edited together with the icon.

[jancborchardt]

I’d also say after the name. And I would even say no icon and just text, also because the icon is not really so understandable (very thin). Since something is edited it also warrants using text rather than just an icon.

The original spec above says this, let’s do it like that:

Amend to the author name (edited) / (edited by moderator-name)

[NoahDar]

Looking forward seeing this get added to talk. Keep up the great work guys! 👍