spreed icon indicating copy to clipboard operation
spreed copied to clipboard

Display name is "null" after reload from being logged out

Open fancycode opened this issue 1 year ago • 2 comments

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Be in a room with a user account and close your laptop over night.
  2. Have your session expire while laptop is closed.
  3. Open your laptop, notice your signaling connection is not reconnected automatically and reload the page (now as anonymous guest user).

Expected behaviour

Display name should have a sensible default value.

Actual behaviour

displayname_null

Experienced on c.n.c in the Talk development room.

fancycode avatar Sep 19 '23 08:09 fancycode

cc @DorraJaouad since you touched the guest names ~~maybe for https://github.com/nextcloud/spreed/pull/10467~~ - master only

UPD.: this could be triggers for this issue:

  • https://github.com/nextcloud/spreed/pull/10475 touched store
  • https://github.com/nextcloud/spreed/pull/10301 touched BrowserStorage

nickvergessen avatar Sep 19 '23 12:09 nickvergessen

There is a "Guest" string as a fallback if the getter getDisplayName() returns null. Will be further checking ...

DorraJaouad avatar Sep 23 '23 18:09 DorraJaouad