serverinfo icon indicating copy to clipboard operation
serverinfo copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

A desperate second attempt to fix #263

Open dertuxmalwieder opened this issue 2 years ago • 2 comments

Based upon the FreeBSD implementation and my own previous attempt... VERY lightly tested.

dertuxmalwieder avatar Jan 31 '23 00:01 dertuxmalwieder

Thanks for your pull request :+1:

I'm not sure how to continue here. The linter and static analysis are failing. That's something we have to fix.

I took your changes a few weeks ago and tried to add some tests: https://github.com/nextcloud/serverinfo/compare/feat/sun-os

The current implementation is a bit unfinished. Sorry, I can't spare the time to finish the unit tests, but I'm happy to answer your questions.

kesselb avatar Apr 23 '23 18:04 kesselb

The current implementation is a bit unfinished.

Yes, I noticed that I made a few mistakes there, some of which caused by copy&paste after the initial version. Sorry for have wasted your time with that. That happens when you (= I) don't give myself enough time... I changed a few things, but yes, the lack of tests is a problem on my side. I wish I wouldn't even had to do that again though ... ;-)

dertuxmalwieder avatar Apr 23 '23 19:04 dertuxmalwieder