serverinfo icon indicating copy to clipboard operation
serverinfo copied to clipboard

Fix mobile view

Open Dennis1993 opened this issue 3 years ago • 5 comments

Fix for https://github.com/nextcloud/serverinfo/issues/385

Before: image

After: image

Signed-off-by: Dennis1993 [email protected]

Dennis1993 avatar Sep 12 '22 13:09 Dennis1993

Thanks! Though I fear it is still not working correctly:

click here

image

Tested with
docker run -it \
-p 8444:443 \
-e TRUSTED_DOMAIN=10.6.0.1 \
-e SERVERINFO_BRANCH=Dennis1993-patch-3 \
-v /:/host/ \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

szaimen avatar Sep 12 '22 14:09 szaimen

Thank you! Why is it not working?! :( On my second testserver it is working too. I don't understand it.

image

Dennis1993 avatar Sep 12 '22 14:09 Dennis1993

Why is it not working?! :( On my second testserver it is working too. I don't understand it.

did you test with multiple connected drives or only with one?

szaimen avatar Sep 12 '22 14:09 szaimen

Both. My testserver A has only one disk and the second testserver has two drives. All other boxes are misaligned without this patch. If I use this patch, all boxed are correct aligned in mobile view.

Dennis1993 avatar Sep 12 '22 14:09 Dennis1993

I just tried again and recorded a video for you:

https://user-images.githubusercontent.com/42591237/189678256-b07e31cc-6e15-447d-9732-27df309e7de4.mp4

szaimen avatar Sep 12 '22 14:09 szaimen

Thank you for the pull request 👍

I am closing it due to the lack of activity. If you have the time to continue, please make a new one.

kesselb avatar Nov 01 '23 14:11 kesselb