serverinfo icon indicating copy to clipboard operation
serverinfo copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Consider replacing while loop in FormatBytes

Open J0WI opened this issue 5 years ago • 1 comments

https://github.com/nextcloud/serverinfo/blob/efeed3479fd048b403c6a72ebf74241a971a065c/templates/settings-admin.php#L28-L36

This doesn't look very efficient and could be replaced with a logarithmic function. Requires check for <= 0.

J0WI avatar May 20 '20 22:05 J0WI

https://3v4l.org/fG7s2/perf https://3v4l.org/PbVrs/perf

kesselb avatar Aug 15 '20 20:08 kesselb

This seems settled and can be closed. :)

joshtrichards avatar Jun 05 '23 16:06 joshtrichards