server icon indicating copy to clipboard operation
server copied to clipboard

fix(settings): update all button only updates a single app

Open AndyScherzinger opened this issue 1 month ago • 2 comments

  • local branch for #56469
  • Resolves: #51318

Summary

Previously, the chain of functions involved in the "update all apps" routine were not properly setup up with regards to asynchronism:

  • The promises generated by updateAll() were not awaited or managed properly
  • The update function fed to p-limit's limit() utility was returning void and not a promise, as it expects (see docs)

This was causing the mechanism driving the updates to potentially end prematurely.

This PR fixes this by:

  • Properly using async/await and Promises.all in updateAll() to ensure all promises generated by p-limit are awaited and executed completely before the function finishes.
  • Making update() return the promises it involves

This would prevent the function from exiting prematurely and ensure all updates are processed automatically.

Checklist

AndyScherzinger avatar Dec 08 '25 15:12 AndyScherzinger

@AndyScherzinger DCO is red. Can we still merge this?

szaimen avatar Dec 08 '25 15:12 szaimen

@szaimen I fixed the DCO 👍

AndyScherzinger avatar Dec 08 '25 15:12 AndyScherzinger