feat(settings): conditionally display developer documentation link based on configuration
Summary
Adds a new application configuration display_documentation_link that allows hiding the developer documentation link in the app settings page.
Changes
-
Controller: Modified
AppSettingsController::viewApps()to conditionally setappstoreDeveloperDocsbased on thedisplay_documentation_linkconfiguration - Tests: Updated existing tests and added two new test cases to verify the conditional behavior
Configuration
-
Config key:
settings→display_documentation_link -
Default value:
true(documentation link is shown) -
Values:
"true"or"false"(as string)
Usage
Hide the documentation link:
occ config:app:set settings display_documentation_link --value="false"
Show the documentation link (default):
occ config:app:set settings display_documentation_link --value="true"
Checklist
- Code is properly formatted
- Sign-off message is added to all commits
- [ ] Tests (unit, integration, api and/or acceptance) are included
- [ ] Screenshots before/after for front-end changes
- [ ] Documentation (manuals or wiki) has been updated or is not required
- [ ] Backports requested where applicable (ex: critical bugfixes)
- [ ] Labels added where applicable (ex: bug/enhancement,
3. to review, feature component) - [ ] Milestone added for target branch/version (ex: 32.x for
stable32)
Hi @Arsalanulhaq,
We would prefer to drop the link from the apps store rather than adding a configuration option for it.
Hi @Arsalanulhaq,
We would prefer to drop the link from the apps store rather than adding a configuration option for it.
Hi @kesselb
So, should we remove the generated developerDocsUrl link in AppsSettingsController.php and its usage in the AppStoreNavigation.vue file directly from the code? Is this link generated or used anywhere else? Because removing it will prevent users from seeing/navigating to the developer documentation.
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
(If you believe you should not receive this message, you can add yourself to the blocklist.)