nextcloud
Run rector on lib/private
- Resolves: #
Summary
Seems to work fine locally and the CI is also happy
I ended up doing some manual changes to lib/private/Group/Group.php, to lib/private/Server.php and to lib/private/AppFramework/DependencyInjection/DIContainer.php to make it work
TODO
- [ ] ...
Checklist
- Code is properly formatted
- Sign-off message is added to all commits
- [ ] Tests (unit, integration, api and/or acceptance) are included
- [ ] Screenshots before/after for front-end changes
- [ ] Documentation (manuals or wiki) has been updated or is not required
- [ ] Backports requested where applicable (ex: critical bugfixes)
- [ ] Labels added where applicable (ex: bug/enhancement,
3. to review, feature component) - [ ] Milestone added for target branch/version (ex: 32.x for
stable32)
We were always a bit hesitant to do this, but I guess we just have to do it at some point. I'm fine with doing it now, if there is anything wrong we hopefully have enough time until 33. GH isn't able to let me see the entire second commit, so I can only really yolo this one.
We were always a bit hesitant to do this, but I guess we just have to do it at some point. I'm fine with doing it now, if there is anything wrong we hopefully have enough time until 33. GH isn't able to let me see the entire second commit, so I can only really yolo this one.
We do need to bit the bullet at some point :)
Batch 2 🥇
Thanks for the careful review :) Applied almost everything, aside of a few things that were breaking some other parts