server icon indicating copy to clipboard operation
server copied to clipboard

fix(settings): update all button only updates a single app

Open tmlmt opened this issue 1 month ago • 2 comments

  • Resolves: #51318

Summary

Previously, the chain of functions involved in the "update all apps" routine were not properly setup up with regards to asynchronism:

  • The promises generated by updateAll() were not awaited or managed properly
  • The update function fed to p-limit's limit() utility was returning void and not a promise, as it expects (see docs)

This was causing the mechanism driving the updates to potentially end prematurely.

This PR fixes this by:

  • Properly using async/await and Promises.all in updateAll() to ensure all promises generated by p-limit are awaited and executed completely before the function finishes.
  • Making update() return the promises it involves

This would prevent the function from exiting prematurely and ensure all updates are processed automatically.

Checklist

tmlmt avatar Nov 15 '25 02:11 tmlmt

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Nov 30 '25 02:11 github-actions[bot]

@susnux @CarlSchwan any chance this can be merged?

DaphneMuller avatar Dec 01 '25 08:12 DaphneMuller