Add empty trash button

[andreasjacobsen93]

It would be nice with a function to empty the trash from the web interface.

Right now you have to do it for every file manually or click the checkbox at top, this could be more obvious with a 'Empty trash' button, which could also warn about the result of doing so.

[MarkusH1975]

Yes please! Please add a 'Empty trash' button

• that each user can empty it's own trash bin
• in the admin area that the adminitrator can empty it for each / all users

Following would be helpful in addition:

• show size of trash bin (user area and admin area)
• delete files older than xx days (freely specified by the user) (good for the admin area as well !)

[MarkusH1975]

I just found some settings in the config.php. Is it possible to add this settings in the admin area webinterface?

https://docs.nextcloud.com/server/12/admin_manual/configuration_server/config_sample_php_parameters.html#deleted-items-trash-bin

as well for the "versions_retention_obligation"

Thanks, Markus

[feutl]

I just found some settings in the config.php. Is it possible to add this settings in the admin area webinterface?

https://docs.nextcloud.com/server/12/admin_manual/configuration_server/config_sample_php_parameters.html#deleted-items-trash-bin

as well for the "versions_retention_obligation"

Thanks, Markus

Which is not working correctly if you are using groupfolders, like mentioned here: https://github.com/nextcloud/groupfolders/issues/99#issuecomment-552940389 https://github.com/nextcloud/groupfolders/issues/464 https://github.com/nextcloud/groupfolders/issues/345

[sorbaugh]

We need to define how this would behave when deleting groupfolders from the Trashbin. Discussing with the Files Team, an idea would be to add a warning when deleting things would impact the trashbin of other users. Alternatively, we decide to simply delete the user-owned stuff.

cc @marcoambrosini

[marcoambrosini]

@sorbaugh I think we could always display a warning dialog, regardless of whether it impacts other users or not. And in case it does, we could show a message that mentions it. I'm also wondering if it would be more appropriate to show this message upon deletion of the group-folder instead of when emptying the thrash bin

MacOS example:

[sorbaugh]

@Pytal, some notes:

• Currently there is no API to display a new button here. Current API can only display actions
  • Possible approach: we can inject elements depending on the view (in this case trashbin) like we do with the filters in the file-list.
  • "Clean" approach: We extend the current API.
• this should also be tested with Groupfolders.
• We should add the confirmation dialog as proposed by @marcoambrosini

@marcoambrosini currently we don't know where to best show this button. Any ideas from design?

[marcoambrosini]

We currently have the breadcrumb component there, and a "New" button too We could remove both of them and just place a heading and the empty thrash button

[j-lakeman]

Is the breadcrumb component the Deleted files writing plus the trash can icon? I'd leave that for orientation TBH. Wouldn't it make sense to just replace the anyway greyed out New by empty trash?

[Pytal]

Is the breadcrumb component the Deleted files writing plus the trash can icon? I'd leave that for orientation TBH. Wouldn't it make sense to just replace the anyway greyed out New by empty trash?

I agree. Sound good @marcoambrosini?