server
server copied to clipboard
Path specific Filesystem setup
- Resolves: #54562
Summary
This branch introduces changes to setupForPath to implement a version that support authoritative mount providers.
TODO
- [x] Check if we ship without the changes for the INodeByPath implementation
Checklist
- Code is properly formatted
- Sign-off message is added to all commits
- [ ] Tests (unit, integration, api and/or acceptance) are included
- [ ] Screenshots before/after for front-end changes
- [ ] Documentation (manuals or wiki) has been updated or is not required
- [ ] Backports requested where applicable (ex: critical bugfixes)
Possible performance regression detected
Show Output
An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/work/server/server/occ(33): require_once('...')
#9 {main}
@artonge and @CarlSchwan had to add two commits to make psalm happy:
- added array_any to psalm stubs
- removed two unnecessary entries from the psalm-baseline
- added
@sinceannotations missing in the new interface and data-class - rewrote a bit the descriptions of the new interface and classes to try be a bit clearer ;)
If those last changes are OK for you (tests are ✅), I'd rebase this branch on master and put that as target, push and then merge once tests are green again.
CodeQL is stuck, probably because of switching target branch. I'll update the branch with rebase to see if the proper CodeQL checks run (should actually be CodeQL Advanced, and not CodeQL) :tired_face: