server icon indicating copy to clipboard operation
server copied to clipboard

fix(ObjectStore): Make S3 "connect_timeout" option configurable

Open danxuliu opened this issue 6 months ago • 3 comments

Follow up to #46317

The hardcoded connection timeout of 5 seconds may not be enough in some cases, so now it is got from the ObjectStore arguments in Nextcloud configuration, falling back to 5 if not set.

The connection timeout is set in seconds, but decimal precision can be used for subsecond accuracy (for example, 4.2 for 4200 milliseconds).

Note that the option is actually http->connect_timeout when passed to the SDK, but it was kept as a flat connect_timeout rather than a nested http->connect_timeout in the ObjectStore arguments for simplicity.

Documentation: https://github.com/nextcloud/documentation/pull/13226

danxuliu avatar Jun 15 '25 07:06 danxuliu

/backport to stable31

danxuliu avatar Jun 15 '25 08:06 danxuliu

/backport to stable30

danxuliu avatar Jun 15 '25 08:06 danxuliu

Failing tests are unrelated and it seems that they were introduced in #53457

danxuliu avatar Jun 15 '25 08:06 danxuliu

Rebased on latest master to (hopefully) get green CI.

danxuliu avatar Jun 16 '25 18:06 danxuliu