nextcloud
fix(previews): Allow to parse big files for previews
- Resolves: https://github.com/nextcloud/server/issues/53469
Checklist
- Code is properly formatted
- Sign-off message is added to all commits
- [ ] Tests (unit, integration, api and/or acceptance) are included
- [ ] Screenshots before/after for front-end changes
- [x] Documentation (manuals or wiki) has been updated or is not required
- [x] Backports requested where applicable (ex: critical bugfixes)
It feels weird to have this as a general option in config.php.
It should be an option for each storage defined in files_external, no? You may want to enable it for an SMB one on local network and disable it for another s3 storage? Or is that too niche?
I agree that having this per storage would be better.
Additionally, allowing the admin to set a different cutoff size instead of just disabling the cutoff altogether would be nice.
Note that there is a "mount options" system that would probably make sense to use to configure this.
They can be set with occ files_external:option <mount id> <key> <value> and then checked with $file->getMountPoint()->getOption($key, $default)
Got it. 👍 In that case, i'm closing here in favour of a "per storage" option.