server icon indicating copy to clipboard operation
server copied to clipboard

When changing file extension ask for confirmation

Open T0mWz opened this issue 1 year ago • 6 comments

We sometimes see users changing a file name, unintentionally / unknowingly deleting the extension dot or removing the whole extension. After which they cannot open the document because it is no longer recognized as such, resulting in user confusion.

Where on an operating system is explicitly asked for confirmation when accidentally changing / deleting an extension. Is there a possibility to check if there is still an extension present when editing, or else give a notification?

Example what an OS will ask you, by changing an extension. remove_extension change_extension

T0mWz avatar Jul 15 '24 10:07 T0mWz

Sounds reasonable and helpful indeed. @sorbaugh @AndyScherzinger @marcoambrosini for Files planning.

jancborchardt avatar Sep 13 '24 13:09 jancborchardt

I'd agree, while @T0mWz mentioned the OS level. So yes, I think this seems reasonable in general and something you can catch on the client level, so (since we are in the server repo) it makes sense to catch this in the WebUI and is would likely also be easily doable for the Mobile apps, yet for Desktop OS we would need to rely on the OS either asking the user, or not asking the user. Screenshots are from MacOS, but I can't say how the different Linux distros or rather their Desktop/file manager handle such renames - Windows behaves the same way like MacOS.

So I would say web and Mobile should check if the file extensions (characters after the last dot changed) and if so launch an expicit confirmation screen with an explanation of the potential consequences as shown above.

AndyScherzinger avatar Sep 13 '24 16:09 AndyScherzinger

Yup, that’s how I also understood, as a function of the web interface (and mobile, yup).

jancborchardt avatar Sep 13 '24 16:09 jancborchardt

This would be a really nice QoL improvement. We'll look into it.

sorbaugh avatar Sep 14 '24 18:09 sorbaugh

This is a Frontend only task.

Some notes:

  • [ ] Also add a "don't ask me again" option
  • [ ] Add a config option
  • [ ] Add the Dialog (probably needs to be added to only 1 place)

Estimation: 3-5 days

sorbaugh avatar Oct 10 '24 09:10 sorbaugh

Assigning @Fenn-CS

sorbaugh avatar Oct 10 '24 09:10 sorbaugh

Image

Looks great, will the don't ask again part be implemented? Or is it tracked somewhere else?

marcoambrosini avatar Jan 20 '25 13:01 marcoambrosini

Problem: It's currently impossible to rename a file, only to change its format. Don't know if this is related to the pr addressing this issue.

cc @sorbaugh @nfebe

marcoambrosini avatar Jan 20 '25 13:01 marcoambrosini