server icon indicating copy to clipboard operation
server copied to clipboard

Filetype filters on top of the files list (doc, pdf, jpg, ...)

Open artonge opened this issue 1 year ago • 2 comments

@nextcloud/designers for mockups

artonge avatar May 22 '24 11:05 artonge

Example from google drive: image

szaimen avatar May 22 '24 14:05 szaimen

@marcoambrosini wanted, in general, to also look at the search bar, but this brings in a whole 'what to do with search' discussion. Best that design comes up with a complete concept.

jospoortvliet avatar May 23 '24 08:05 jospoortvliet

@nextcloud/designers can we have some proper mockups for that?

artonge avatar May 29 '24 13:05 artonge

Kickoff call outcome @AndyScherzinger @artonge @susnux @szaimen

  • We start with filters but with taking into account that in the future we might add a search bar
  • More than just file type: also add "people" and "modified" like google
  • We keep the filters just above the files list and below all rich documents and recommended files Open question: do these filters only filter the current folder or are they recursive? E.g. when I filter for "documents" in a folder, do I see all documents in the whole folder tree or just the ones present in the current folder? From a UX perspective I think the former is the most beneficial, but it's much more difficult to achieve technically. It's also what our competitors do when using these filters. @susnux suggested that there could be a switch between current folder and all subfolder filtering. From a visual design perspective little will change regardless of what we choose so we go ahead with the mockups

Also cc @karlitschek and @jancborchardt

Current rough idea of the worst case scenario (Recommended files in root folder + rich workspaces enabled)

Image

Current rough idea of the best case scenario (subfolder with no rich workspaces)

Image

marcoambrosini avatar Jun 03 '24 13:06 marcoambrosini

@marcoambrosini seems good, some feedback:

  • Can we just call it "Type" instead of "File type", much nicer and compact.
  • The dropdowns have some uniform width which looks off with the extra whitespace between text and down arrow. Would look nicer if it’s only as wide as needed.
  • How does it look when the dropdowns are opened? I assume either like in Google Drive or in our search, but would be good to clarify.

Open question: do these filters only filter the current folder or are they recursive? E.g. when I filter for "documents" in a folder, do I see all documents in the whole folder tree or just the ones present in the current folder? From a UX perspective I think the former is the most beneficial, but it's much more difficult to achieve technically. It's also what our competitors do when using these filters. @susnux suggested that there could be a switch between current folder and all subfolder filtering.

I would first go with what is doable technically in a nice way, we can always improve on that. But no to a switch between modes here, that would needlessly complicate it.

jancborchardt avatar Jun 05 '24 09:06 jancborchardt

susnux suggested that there could be a switch between current folder and all subfolder filtering.

I would first go with what is doable technically in a nice way, we can always improve on that. But no to a switch between modes here, that would needlessly complicate it.

To clarify for me it is about having two options:

  1. Filter the current folder (e.g. if there are a lot of file, I know the folder but I just want to filter)
  2. Search for something (e.g. search for a PDF somewhere in the file tree

susnux avatar Jun 05 '24 10:06 susnux

Questions: What file type filters do we use? All types we found in the list? Or a generic list like

  • folders
  • documents (like office, spreadsheets and presentations)
  • Images
  • Videos
  • Audio

(this list would be easy to implement)

Or more like specific files? (PDF, JPG...)

What does "Modified" filter? "yesterday" "last week"?

People: Should this only filter the owner?

susnux avatar Jun 05 '24 10:06 susnux

@susnux for all of these, I would follow Google Drive’s lead since that’s the solution spearheading this. cc @marcoambrosini

jancborchardt avatar Jun 05 '24 11:06 jancborchardt

I started implementing it, but have a question: The mock up is using a drop down, shall we use it or go with actions? Especially for user filtering a drop down would be a completely new component to allow two menu levels (1. user 2. "shared the file", "owned the file", etc)

With a drop down it looks like this:

Screencast_20240605_223801.webm

susnux avatar Jun 05 '24 20:06 susnux

Screenshot 2024-06-06 at 10 56 40

Hi @susnux, I think we should go with actions like in the global search. The different look is because of the smaller border radii but I was thinking about the actions component.

marcoambrosini avatar Jun 06 '24 08:06 marcoambrosini

@marcoambrosini with actions it could look like this:

https://github.com/nextcloud/server/assets/1855448/ad6d4116-c203-4a77-8e3c-3919939e13d4

susnux avatar Jun 07 '24 11:06 susnux

@susnux nice! Could "Clear filter" go to the bottom of the action menu so the entries don’t all jump one down?

jancborchardt avatar Jun 12 '24 14:06 jancborchardt

Could "Clear filter" go to the bottom of the action menu

Sure but then you need to scroll fully down to clear, is that ok?

susnux avatar Jun 12 '24 22:06 susnux

The related PR: https://github.com/nextcloud/server/pull/45708

sorbaugh avatar Jul 03 '24 08:07 sorbaugh