server icon indicating copy to clipboard operation
server copied to clipboard

[Bug]: NC 28.0.2 - Icons in toolbar are black instead of white

Open arnowelzel opened this issue 1 year ago • 1 comments

⚠️ This issue respects the following points: ⚠️

Bug description

All icons in the toolbar are black instead of white.

Steps to reproduce

  1. Upgrade von NC 28.0.1 to 28.0.2
  2. See icons in the tab bar to be black instead of white

Expected behavior

Icons in the tab bar are white and not black.

Installation method

Community Web installer on a VPS or web space

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 22.1 to 22.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • [ ] Default user-backend (database)
  • [ ] LDAP/ Active Directory
  • [ ] SSO - SAML
  • [ ] Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

image

arnowelzel avatar Feb 02 '24 17:02 arnowelzel

As a workaround I added the following custom CSS:

#header {
  --background-image-invert-if-bright: none;
}

I understand the intention of the original filter invented with NC 28.0.2 - but maybe it would be better to have some option for the icon color instead of a filter.

Edit: another "fix" is to make the background color a bit darker in the personal settings, so the filter to change the icon color to black will not trigger. However this will only work individually for a single user account and the "active tab" pill is still wrong (always white even with black app icons). Having the possibility to define a global system wide theme including the icon colors (and the "active tab" pill of course) would be much better.

arnowelzel avatar Feb 02 '24 17:02 arnowelzel

I also have this issue. The fix @arnowelzel gave worked for the header icons, but in my case the favicons are also generated as black on blue and are not fixed.

ozls avatar Feb 03 '24 08:02 ozls

I also have this issue. The fix @arnowelzel gave worked for the header icons, but in my case the favicons are also generated as black on blue and are not fixed.

Did you try to clear the cache of your browser? In my case the favicons are ok, but I cleared the browser cache after adding the custom CSS

arnowelzel avatar Feb 03 '24 09:02 arnowelzel

I also have this issue. The fix @arnowelzel gave worked for the header icons, but in my case the favicons are also generated as black on blue and are not fixed.

Did you try to clear the cache of your browser? In my case the favicons are ok, but I cleared the browser cache after adding the custom CSS

I stand corrected - indeed some apps have black favicons, but not all of them. I don't understand, how this can happen at all. Even if the favicons are generated, the colors used for that should be based on global preferences and not depending on some app specific rules.

Correct favicons:

Files: image

Activity: image

Contacts: image

Calendar: image

Deck: image

Collectives: image

Tasks: image

Wrong favicons:

Photos: image

Notes: image

arnowelzel avatar Feb 03 '24 10:02 arnowelzel

The color of the text is based on your background color, it is chosen to have at least 4.5:1 contrast, meaning if you make the background color a bit darker it will be white text.

susnux avatar Feb 03 '24 13:02 susnux

Changing the tone of blue solved it for me, thank you @susnux. I don't believe the behavior should have changed like this, but I guess that is another debate.

ozls avatar Feb 04 '24 10:02 ozls

Just updated to 29.0.0 and it is not fixed. Icons are still black.

There is a filter applies, when shouldn't

.app-menu-main .app-menu-entry img[data-v-62f74e6b] {
  filter: var(--background-image-invert-if-bright);
}

regs01 avatar May 06 '24 05:05 regs01