server
server copied to clipboard
nextcloud
[Bug]: Theme color not applied properly to icons
⚠️ This issue respects the following points: ⚠️
- [X] This is a bug, not a question or a configuration/webserver/proxy issue.
- [X] This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- [X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- [X] I agree to follow Nextcloud's Code of Conduct.
Bug description
After the recent upgrade to Nextcloud 28 the theme color for icons isn't applied correctly anymore.
In this picture you can see the folder icon color correctly matches the theme color, archive and document icons ignore the selected color.
Steps to reproduce
- Select a custom theme color
- Upload a compressed archive
- Check the icon color in nextcloud web GUI
Expected behavior
Theme color should be applied consistently to choice.
Installation method
Community Manual installation with Archive
Nextcloud Server version
28
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.2
Web server
Apache (supported)
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Update
After the update to 28.0.2 the theme color is totally ignored even for folders and selection highlight.
This bug can be reproduced when it is selected "Dark Theme" in "Appearance and accessibility settings".
I think this might happen due to some places that still use the primary color instead of the every-where-else-used primary-element color.
https://github.com/nextcloud/server/blob/672923f0a6ab5a692273326250fe1394b4e41bd9/lib/private/Preview/MimeIconProvider.php#L85-L88
I guess some icons are still not fixed :see_no_evil: I think we can either:
- move mime icons to the default grey or their brand color (like docx being blue, pdf being red...)
- add back mime icon theming (I think this doesn't really add much anyway and is over engineered)
In this picture you can see the folder icon color correctly matches the theme color, archive and document icons ignore the selected color.
I have to correct myself. This is by design. Folders are color primary, while documents are by design always that blue. Like pdf is always red, documents are always blue.