server icon indicating copy to clipboard operation
server copied to clipboard

Design: App Icons not consistent with right side buttons

Open pschopen opened this issue 1 year ago • 11 comments

Normally, App Icons in the top left are half-transparent, as the icons on the top right side (search, notifications, users). However in NC 28.0.1 they aren't, but 100% white instead.

20231221_203200.png

pschopen avatar Dec 21 '23 19:12 pschopen

This is intended as otherwise the contrast ratio for background to icon is too low, see https://github.com/nextcloud/server/issues/36967

susnux avatar Dec 22 '23 00:12 susnux

And for the right side? Shouldn't it be consistent?

pschopen avatar Dec 22 '23 05:12 pschopen

Good question.

@nextcloud/designers should we adjust the menu? So that app icons and the right side buttons (search, contacts, notifications) have the same hover styles and appearance?

susnux avatar Dec 22 '23 08:12 susnux

Yes they should have the same appearance

marcoambrosini avatar Dec 22 '23 09:12 marcoambrosini

@marcoambrosini but what is then the hover state? For app icons the text is made bold. But those buttons do not have text?

susnux avatar Dec 22 '23 10:12 susnux

(connected issue: https://github.com/nextcloud/server/issues/42441 )

susnux avatar Dec 22 '23 10:12 susnux

@susnux we don't strictly need a hover state, the contrast of the icon with its background is much more important

marcoambrosini avatar Jan 08 '24 10:01 marcoambrosini

we don't strictly need a hover state

Yes but we should be consistent.

susnux avatar Jan 09 '24 17:01 susnux

Yes, we can have them 100% opacity and no hover state

marcoambrosini avatar Jan 10 '24 09:01 marcoambrosini

Related to https://github.com/nextcloud/server/issues/42954?

nursoda avatar Feb 15 '24 13:02 nursoda

Related to https://github.com/nextcloud/server/issues/42954?

no

susnux avatar Feb 15 '24 15:02 susnux