server icon indicating copy to clipboard operation
server copied to clipboard

[BITV]: Skip links are not working anymore

Open JuliaKirschenheuter opened this issue 2 years ago • 7 comments

Try to navigate via skip links to "main content" or "navigation". Nothing happens.

Peek 2023-11-23 15-44

JuliaKirschenheuter avatar Nov 23 '23 14:11 JuliaKirschenheuter

Do we know what the purpose of these buttons are supposed to do? Do they re-route to the top of the page, AKA, the main part of the page?

emoral435 avatar Dec 19 '23 17:12 emoral435

@emoral435 thank you for the question. More theory behind it: https://webaim.org/techniques/skipnav/#maincontent

For us it is important to have a quick access to the left navigation and to the main content. If user select "main content" then a next navigation point (via tab) have to start from the first element on the main content (like a table in a files view). If user would select "navigation" then the focus have to the first element in a left side navigation. It is just an anchor and helps quick navigation possibilities through a page.

JuliaKirschenheuter avatar Dec 21 '23 10:12 JuliaKirschenheuter

It seems to depend on the app. Still working for me on collectives app for example. Not in files.

max-nextcloud avatar Dec 21 '23 10:12 max-nextcloud

Apps that do not use the default app-content or app-navigation IDs need to set the correct IDs in their PHP view controller. For reference see the dashboard app.

I created a general solution for Vue apps (as all of them are affected): https://github.com/nextcloud-libraries/nextcloud-vue/pull/4983

susnux avatar Dec 21 '23 12:12 susnux

Only fixed for files app - we still need the library PR.

susnux avatar Dec 21 '23 14:12 susnux

Seems to work in the files and dashboard app but not in the photos and activity app

szaimen avatar Jan 26 '24 09:01 szaimen

Seems to work in the files and dashboard app but not in the photos and activity app

Requires nextcloud vue 8.5.0

susnux avatar Jan 26 '24 10:01 susnux

Works everywhere except the activity app in stable28

szaimen avatar Feb 05 '24 10:02 szaimen