"Share with" wording fix in new share panel

[Jerome-Herbinet]

Summary

• Removing space ; so we get "Share with" instead of "Share with " and adding space after translation call (because, IMO a space at the end of a wording is not a good idea)
• Replacing "Share" with "Shared", because, IMO, it's more relevant and consistent (isn't it ?)

Note : I require a syntax checking concerning the moved space character.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• [ ] Tests (unit, integration, api and/or acceptance) are included
• [ ] Screenshots before/after for front-end changes
• [ ] Documentation (manuals or wiki) has been updated or is not required
• [ ] Backports requested where applicable (ex: critical bugfixes)

[rakekniven]

Can someone please add a screenshot here? I was unable to find the occurence of given string in web UI using NC v27.1.3 .

[Jerome-Herbinet]

Can someone please add a screenshot here? I was unable to find the occurence of given string in web UI using NC v27.1.3 .

@rakekniven :

[jancborchardt]

Both in that heading and in the button, the word "share" is a noun, so it’s correct to have it called "share" and not "shared". :)

[nfebe]

@jancborchardt So what is the conclusion? So I can implement it.

[susnux]

Sorry to tackle your PR but I pushed a commit to show what I mean, because this will allow to translate the sentence independent of sentence order of the language. Feels free to drop that commit if not happy with it :)

[Jerome-Herbinet]

If I understand well, this PR hasn't been merged into Nextcloud 29 ; what was the problem ?

[Jerome-Herbinet]

@jancborchardt it's fixed in NC 29 (maybe since 28 and maybe in NC 30 I hope = no regression) so I close my PR which is useless now.

[jancborchardt]

@Jerome-Herbinet yep, sorry that it didn’t come with your pull request, but let’s be happy it was fixed either way. :)