server icon indicating copy to clipboard operation
server copied to clipboard

[master] Update psalm-baseline.xml

Open nextcloud-command opened this issue 2 years ago • 2 comments
trafficstars

Auto-generated update psalm-baseline.xml with fixed psalm warnings

nextcloud-command avatar Sep 30 '23 02:09 nextcloud-command

Rebased, updated baseline and attempted to fix baseline updating workflow.

The baseline I pushed is full of CDATA because of https://github.com/vimeo/psalm/issues/10632 It should not be a problem, let’s see what CI thinks of it.

come-nc avatar Feb 01 '24 16:02 come-nc

While on it, can we enforce the correct PHP version as baseline: https://github.com/nextcloud/spreed/blob/main/psalm.xml#L8 Otherwise you can use PHP 8.2 functions and psalm will not complain :P

nickvergessen avatar Feb 01 '24 17:02 nickvergessen

While on it, can we enforce the correct PHP version as baseline: nextcloud/spreed@main/psalm.xml#L8 Otherwise you can use PHP 8.2 functions and psalm will not complain :P

The psalm jobs already run on 8.0, and our composer.json lists 8.0 as php platform, should be enough, no?

come-nc avatar Feb 05 '24 08:02 come-nc

/backport 40ab40de30ee90ded277065da206aa3830a2f796to stable28

come-nc avatar Feb 06 '24 09:02 come-nc

/backport 40ab40de30ee90ded277065da206aa3830a2f796 to stable28

come-nc avatar Feb 06 '24 09:02 come-nc

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/40725/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 40ab40de

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/40725/stable28

Error: Failed to push branch backport/40725/stable28: To https://github.com/nextcloud/server.git ! [remote rejected] backport/40725/stable28 -> backport/40725/stable28 (refusing to allow a GitHub App to create or update workflow .github/workflows/update-psalm-baseline.yml without workflows permission) error: failed to push some refs to 'https://github.com/nextcloud/server.git'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot[bot] avatar Feb 06 '24 09:02 backportbot[bot]